fix: [#176740861] Remove from store/readState a not found service (#2868

) * [#176740861] add reducer logic and tests * [#176740861] update comment Co-authored-by: Cristiano Tofani <[email protected]>
pagopa · Mar 17, 2021 · 64c4a41 · 64c4a41
1 parent 6e44188
commit 64c4a41
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 1 deletion.
diff --git a/ts/sagas/startup/loadServiceDetailRequestHandler.ts b/ts/sagas/startup/loadServiceDetailRequestHandler.ts
@@ -6,6 +6,7 @@ import { Millisecond } from "italia-ts-commons/lib/units";
 import { BackendClient } from "../../api/backend";
 import {
   loadServiceDetail,
+  loadServiceDetailNotFound,
   loadServicesDetail
 } from "../../store/actions/services";
 import { SagaCallReturnType } from "../../types/utils";
@@ -14,6 +15,7 @@ import { handleServiceReadabilitySaga } from "../services/handleServiceReadabili
 import { totServiceFetchWorkers } from "../../config";
 import { applicationChangeState } from "../../store/actions/application";
 import { mixpanelTrack } from "../../mixpanel";
+import { ServiceId } from "../../../definitions/backend/ServiceId";
 
 /**
  * A generator to load the service details from the Backend
@@ -43,6 +45,9 @@ export function* loadServiceDetailRequestHandler(
       // Update, if needed, the name of the organization that provides the service
       yield call(handleOrganizationNameUpdateSaga, response.value.value);
     } else {
+      if (response.value.status === 404) {
+        yield put(loadServiceDetailNotFound(action.payload as ServiceId));
+      }
       throw Error(`response status ${response.value.status}`);
     }
   } catch (error) {

diff --git a/ts/store/actions/services.ts b/ts/store/actions/services.ts
@@ -40,6 +40,10 @@ type ServiceLoadFailurePayload = {
   service_id: string;
 };
 
+// a specific action used when a requested service is not found
+export const loadServiceDetailNotFound = createStandardAction(
+  "LOAD_SERVICE_DETAIL_NOT_FOUND"
+)<ServiceId>();
 export const loadServiceDetail = createAsyncAction(
   "LOAD_SERVICE_DETAIL_REQUEST",
   "LOAD_SERVICE_DETAIL_SUCCESS",
@@ -78,4 +82,5 @@ export type ServicesActions =
   | ActionType<typeof loadServicesDetail>
   | ActionType<typeof markServiceAsRead>
   | ActionType<typeof removeServiceTuples>
-  | ActionType<typeof showServiceDetails>;
+  | ActionType<typeof showServiceDetails>
+  | ActionType<typeof loadServiceDetailNotFound>;
diff --git a/ts/store/reducers/entities/services/__tests__/readStateByServiceId.test.ts b/ts/store/reducers/entities/services/__tests__/readStateByServiceId.test.ts
@@ -0,0 +1,53 @@
+import { OrganizationFiscalCode } from "italia-ts-commons/lib/strings";
+import { appReducer } from "../../../index";
+import {
+  loadServiceDetailNotFound,
+  markServiceAsRead,
+  showServiceDetails
+} from "../../../../actions/services";
+import { ServicePublic } from "../../../../../../definitions/backend/ServicePublic";
+import { ServiceId } from "../../../../../../definitions/backend/ServiceId";
+import { ServiceName } from "../../../../../../definitions/backend/ServiceName";
+import { NotificationChannelEnum } from "../../../../../../definitions/backend/NotificationChannel";
+import { OrganizationName } from "../../../../../../definitions/backend/OrganizationName";
+import { DepartmentName } from "../../../../../../definitions/backend/DepartmentName";
+
+const mockService: ServicePublic = {
+  department_name: "dev department name" as DepartmentName,
+  organization_fiscal_code: "00000000001" as OrganizationFiscalCode,
+  organization_name: "Ramella, Zanetti and Maggiani [1]" as OrganizationName,
+  service_id: "id1" as ServiceId,
+  service_name: "reinventate next-generation architetture" as ServiceName,
+  available_notification_channels: [NotificationChannelEnum.EMAIL],
+  version: 1
+};
+
+describe("readServicesByIdReducer", () => {
+  it("should be read", () => {
+    const state = appReducer(undefined, showServiceDetails(mockService));
+    expect(state.entities.services.readState.id1).toBeTruthy();
+  });
+
+  it("should be read", () => {
+    const state = appReducer(undefined, markServiceAsRead("id2" as ServiceId));
+    expect(state.entities.services.readState.id2).toBeTruthy();
+  });
+
+  it("should be undefined", () => {
+    const state = appReducer(undefined, showServiceDetails(mockService));
+    expect(state.entities.services.readState.id3).toBeUndefined();
+  });
+
+  it("should remove a specific not found service read state", () => {
+    const state1 = appReducer(undefined, markServiceAsRead("id1" as ServiceId));
+    const state2 = appReducer(state1, markServiceAsRead("id2" as ServiceId));
+    expect(state2.entities.services.readState.id1).toBeTruthy();
+    expect(state2.entities.services.readState.id2).toBeTruthy();
+    const updateState = appReducer(
+      state2,
+      loadServiceDetailNotFound("id1" as ServiceId)
+    );
+    expect(updateState.entities.services.readState.id1).toBeUndefined();
+    expect(state2.entities.services.readState.id2).toBeTruthy();
+  });
+});
diff --git a/ts/store/reducers/entities/services/readStateByServiceId.ts b/ts/store/reducers/entities/services/readStateByServiceId.ts
@@ -1,5 +1,7 @@
 import { getType } from "typesafe-actions";
+import _ from "lodash";
 import {
+  loadServiceDetailNotFound,
   markServiceAsRead,
   showServiceDetails
 } from "../../../actions/services";
@@ -36,6 +38,8 @@ export function readServicesByIdReducer(
         ...state,
         [action.payload]: true
       };
+    case getType(loadServiceDetailNotFound):
+      return _.omit(state, [action.payload]);
     // reset reading state if current profile is different from the previous one
     case getType(differentProfileLoggedIn):
       return INITIAL_STATE;