Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLS-38 - Enable DER signature validation #43

Merged
merged 7 commits into from
Apr 27, 2023
Merged

SLS-38 - Enable DER signature validation #43

merged 7 commits into from
Apr 27, 2023

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Apr 27, 2023 •
edited
Loading

List of Changes

  • Implemented transcoding of ASN.1/DER signature using nimbus jose jwt library, and related validation checks for signatures

Motivation and Context

The library should be able to validate ecdsa signatures in ASN.1/DER format

How Has This Been Tested?

  • Defined tests to verify DER signature transcoding and validation on ecdsa-sha256

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

@github-actions
Copy link

File Coverage [89.15%] 🍏
LollipopConsumerConverterTest.java 100% 🍏
LollipopConsumerConverter.java 90.14% 🍏
VismaHttpMessageVerifierTest.java 89.39% 🍏
HttpVerifierHandlerInterceptor.java 86.84% 🍏
VismaHttpMessageVerifier.java 84.42% 🍏
Total Project Coverage 90.36% 🍏

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.7% 88.7% Coverage
0.0% 0.0% Duplication

@alessio-cialini alessio-cialini changed the title Sls 38 SLS-38 - Enable DER signature validation Apr 27, 2023
@alessio-cialini alessio-cialini merged commit 5cde849 into 1.0.0-RC1 Apr 27, 2023
@alessio-cialini alessio-cialini mentioned this pull request Apr 27, 2023
Merged
@alessio-cialini alessio-cialini deleted the SLS-38 branch May 4, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-cialini @svariant