Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLS-19] Rest client implementation for Identity Service #18

Merged
merged 38 commits into from
Apr 12, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Apr 12, 2023

List of Changes

  • Generated rest client using openAPI generator
  • Defined methods that retrieves the idp certification data based on the given entityId and assertion issue instant
  • Written tests to validate IdpCertSimpleClient class methods
  • Removed unused classes from assertion-rest-client-native & identity-service-rest-client-native
  • Defined two configuration classes for the respective ApiClient of IdpCertSimpleClient & AssertionSimpleClient

Motivation and Context

Issue SLS-19 Rest client implementation for Identity Service

How Has This Been Tested?

We've written tests for the following events:

  • Retrieving successfully a SPID certification
  • Retrieving successfully a CIE certification
  • Verify that the correct error is shown when given a non-existing entityID
  • Verify that the correct error is shown when given a wrong instant for SPID certifications
  • Verify that the correct error is shown when given a wrong instant for CIE certifications

Types of changes

[X] Chore (nothing changes by a user perspective)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

@alessio-cialini alessio-cialini merged commit a3fc725 into core-sprint-2 Apr 12, 2023
This was referenced Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants