-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styles for tasklist #83
base: master
Are you sure you want to change the base?
Conversation
This is a great idea and simple implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, though it would be great to test this on all major browsers.
Some feedback in my scope. Windows - ChromeAs seen as in PR description. I dont remember the version I took the snapshot with 😟. Now I have 94.0.4606.81 and it looks the same. Windows - Edge 94.0.992.38Windows - IE 11.0.9600.19596 or minor
Here some pointcut CSS hacks: https://browserstrangeness.bitbucket.io/css_hacks.html |
Still better than what we started with! |
I believe Microsoft is trying to migrate to Edge and away from Internet Explorer, so this shouldn't be a huge issue. Safari, Chrome, and Firefox on Mac look good to me. |
(I left GitHub and can't merge this, but I give it my approval!) |
I have in my backlog apply some IE11- hack to remove this decoration. I'll also try to increase checkboxes size to be pixel perfect more or less. |
در تاریخ چهارشنبه ۱۳ اکتبر ۲۰۲۱، ۲۳:۱۰ David Ordás <
***@***.***> نوشت:
… Still better than what we started with!
I have in my backlog apply some IE11- hack to remove this decoration. I'll
also try to increase checkboxes size to be pixel perfect more or less.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOOITSZLOC6I3O7AUW5JWFLUGXOELANCNFSM5DDFHWQQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Would prefer this kept open. |
Generate styles for tasklist preserving theme colors
to
A complete implement for #75. Resolves #75
Preview a demo at https://davorpa.github.io/github-pages-themes-hacker/#what-about-task-lists