Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google gtags (Google Analytics v4) #64

Closed
wants to merge 2 commits into from
Closed

Add support for Google gtags (Google Analytics v4) #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8808d2
Add support for Google gtags (Google Analytics v4)
f0rked Nov 1, 2020
7ce41da
Move meta tags to the beginning of the head
f0rked Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,11 @@ Additionally, you may choose to set the following optional variables:
```yml
show_downloads: ["true" or "false" to indicate whether to provide a download URL]
google_analytics: [Your Google Analytics tracking ID]
google_analytics_v4: [Your Google Analytics v4 (gtags) tracking ID]
```

`google_analytics` and `google_analytics_v4` are incompatible, you have to choose one of them, if both are set the later takes precedence.

### Stylesheet

If you'd like to add your own custom styles:
Expand Down
13 changes: 13 additions & 0 deletions _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@
<meta charset='utf-8'>
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
{% if site.google_analytics_v4 %}
<!-- Global site tag (gtag.js) - Google Analytics -->
<script async src="https://www.googletagmanager.com/gtag/js?id={{ site.google_analytics_v4 }}"></script>
<script>
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());

gtag('config', '{{ site.google_analytics_v4 }}');
</script>
{% endif %}
Comment on lines +7 to +17
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f0rked good implementation allowing both support!!

Remember that to pass W3C validation the meta charset must be in the first 1024 characters of page.

Can you move the scripts blocks below, for example at end of head tag?

Copy link
Author

@f0rked f0rked Nov 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, the Google script has to be the first one so I moved all the meta tags to the beginning. Now is passing the html validations.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion should be placed after {% seo %} tag.

I have installed this theme in my sites and this is what generates:
Screenshot from 2020-11-05 22-15-14

For SEO I think it's better have the metas, title... near to top. I usually put scripts as lastest, not all browsers accepts async or defer attributes in them:

Are you agree?

<link rel="stylesheet" href="{{ '/assets/css/style.css?v=' | append: site.github.build_revision | relative_url }}">

{% seo %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion should be placed after {% seo %} tag.

I have installed this theme in my sites and this is what generates:
Screenshot from 2020-11-05 22-15-14

For SEO I think it's better have the metas, title... near to top. I usually put scripts as lastest, not all browsers accepts async or defer attributes in them:

Are you agree?

Expand Down Expand Up @@ -35,6 +46,7 @@ <h2>{{ site.description | default: site.github.project_tagline }}</h2>
</div>

{% if site.google_analytics %}
{% unless site.google_analytics_v4 %}
<script>
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
Expand All @@ -43,6 +55,7 @@ <h2>{{ site.description | default: site.github.project_tagline }}</h2>
ga('create', '{{ site.google_analytics }}', 'auto');
ga('send', 'pageview');
</script>
{% endunless %}
{% endif %}
</body>
</html>