Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Honey Gather and Pickup will only activate if the battle was won #4903

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Nov 18, 2024

What are the changes the user will see?

Honey Gather and Pickup will now only activate if the player wins the battle (ie: the enemy Pokémon were fainted; neither the player nor the enemy ran away).

Why am I making these changes?

Fixes #4898

What are the changes from a developer perspective?

BattleEndPhase's isVictory parameter is no longer set to true if either the player or enemy ran away, and it's passed to applyPostBattleAbAttrs() so Honey Gather and Pickup can check if it's true or false.

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • [ ] Have I provided screenshots/videos of the changes?

@DayKev DayKev added Ability Affects an ability P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Nov 18, 2024
@DayKev DayKev marked this pull request as ready for review November 19, 2024 05:44
@DayKev DayKev requested a review from a team as a code owner November 19, 2024 05:44
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some stats that should be updated outside of a victory but aren't, namely:

  • battles (L23, counts total number of battles)
  • highestEndlessWave (L27-29)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Honey Gather activating after Run Away
2 participants