[Bug] Honey Gather and Pickup will only activate if the battle was won #4903
+92
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Honey Gather and Pickup will now only activate if the player wins the battle (ie: the enemy Pokémon were fainted; neither the player nor the enemy ran away).
Why am I making these changes?
Fixes #4898
What are the changes from a developer perspective?
BattleEndPhase
'sisVictory
parameter is no longer set totrue
if either the player or enemy ran away, and it's passed toapplyPostBattleAbAttrs()
so Honey Gather and Pickup can check if it'strue
orfalse
.How to test the changes?
Checklist
beta
as my base branch[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test
)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?