Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pip-28 prevent node shotdowns #154

Merged
merged 16 commits into from
Jul 22, 2024
Merged

docs: add pip-28 prevent node shotdowns #154

merged 16 commits into from
Jul 22, 2024

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Jul 6, 2024

No description provided.

@Ja7ad Ja7ad requested a review from b00f July 6, 2024 08:16
@github-actions github-actions bot added the w-ci label Jul 6, 2024
@github-actions github-actions bot removed the w-ci label Jul 6, 2024
@kehiy
Copy link
Contributor

kehiy commented Jul 6, 2024

@Ja7ad
I think this is not a protocol change and its related to implementation. any implementation can have any features that won't change the protocol. So, it can be an issue on the https://github.com/pactus-project/pactus repo instead of an improvement proposal since it's only a software change.

If we put every software feature on PIPs we will have a huge number of PIPs then.

PIPs/pip-28.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci label Jul 9, 2024
@b00f
Copy link
Collaborator

b00f commented Jul 10, 2024

Do we really need this feature? How much complexity we add to software to implement this feature?

@Ja7ad
Copy link
Collaborator Author

Ja7ad commented Jul 12, 2024

Do we really need this feature? How much complexity we add to software to implement this feature?

This is does not have complexity, just handle in main function daemon, in node we have consensus manager and we can check if validators in committee.

We show a warn confirmation.

Copy link

The commit 79cb4e6 (as a parent of 08fdab4) contains errors.
Please inspect the Run Summary for details.

@b00f b00f merged commit 37d786e into main Jul 22, 2024
4 of 5 checks passed
@b00f b00f deleted the pip-28 branch July 22, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants