Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-27: add PIP-27 for Pruned Node #132

Merged
merged 2 commits into from
Jun 23, 2024
Merged

pip-27: add PIP-27 for Pruned Node #132

merged 2 commits into from
Jun 23, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Jun 22, 2024

This PR drafts a new PIP to define Pruned Nodes in Pactus.
It is in draft mode and should be discussed and get completed.

@github-actions github-actions bot added the w-ci label Jun 22, 2024
Copy link

The commit 4802812 (as a parent of 7d7703b) contains errors.
Please inspect the Run Summary for details.

@Ja7ad
Copy link
Collaborator

Ja7ad commented Jun 23, 2024

@b00f Please fix lint issue first.

@github-actions github-actions bot removed the w-ci label Jun 23, 2024
@Ja7ad Ja7ad merged commit 35f8769 into pactus-project:main Jun 23, 2024
5 checks passed
@@ -0,0 +1,127 @@
---
pip: 27
title: Pruned Node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to call it light node or light client since every protocol did it. I mean everyone knows this concept as the light client so it can cause misunderstanding.

We need to add a new command named `import` to `pactus-daemon`.
The `import` command shows a list of available databases that can be imported from a centralized server.
Once the user chooses a database, it downloads and extracts it into the working directory.
If a database already exists, it should show an error before downloading.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the pruned node is downloading only some part of the chain! not the whole chain from Genesis, so can we still trust the centralized server by verifying?

We are only verifying and seeing some parts of the chain, is there any way for manipulation by a centralized server?

And one more important issue, we are syncing some blocks at all, what about indexed data extracted from transactions? balances, stakes, and in future contracts states?

When we have a whole chain, we can retrieve states by reading whole blocks and indexing the changes that a transaction makes, such as bonding a new validator, sending a native coin, or a contract deploy.

But when we don't have the whole chain we need these data and we need to verify them as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's continue this discussion on #134

@b00f b00f changed the title pip-27: add PIP-27 for Proned Node pip-27: add PIP-27 for Pruned Node Jun 24, 2024
@b00f b00f deleted the pip-27 branch June 24, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants