Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support onChecked and onUnchecked events in the ReactSDK #81

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

jasonabrown
Copy link
Contributor

@jasonabrown jasonabrown commented Sep 15, 2023

Add support for onChecked and onUnchecked snippet events in the ReactSDK.(https://ironcladapp.atlassian.net/browse/IRON-25322).

Manual Testing

Verified locally

Regression Risks

-None

@mewelling mewelling requested a review from a team September 25, 2023 11:57
Copy link
Contributor

@mewelling mewelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonabrown approving, but can you set some time to walk through this with @tstutson so that we can hand off to QE? Alternatively, if we had a loom or something of how it worked i'd be fine with that, too!

@jasonabrown
Copy link
Contributor Author

@mewelling - added a loom to the JIRA.

@cdhcs1516
Copy link
Contributor

@jasonabrown thanks for working on this. Could you also update the ReadMe?

@jasonabrown
Copy link
Contributor Author

@cdhcs1516 - I updated the ReadMe.

Copy link
Contributor

@cdhcs1516 cdhcs1516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving this!

@jasonabrown jasonabrown merged commit b62af0e into main Oct 10, 2023
@mewelling mewelling deleted the onChecked-and-onUnchecked-events branch November 13, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants