[IRON-14173] - Make updates to force scroll

[kelvinjue]

IRON-14173

Bug fix for force scroll. Issue would arise when the prop wasn't passed in for a group, but it was set on the group settings. The prop would result in passing back something like force_scroll: undefined, which would conflict with the group setting. The changes include clearing out fields that are undefined from the group options.

Also making an update to fix behavior attached to a change for retrieveHTML. This would alter the behavior of retrieveHTML, so that it wouldn't reset virtual group properties. But the React SDK depends on that behavior right now to pull settings from the site.

[Wilsonl9]

@kelvinjue Hmm, thats pretty odd. Normally, doesnt undefined get left out of the objects? in this case, they are actually overwriting the values with undefined?

[kelvinjue]

@kelvinjue Hmm, thats pretty odd. Normally, doesnt undefined get left out of the objects? in this case, they are actually overwriting the values with undefined?

Yup, that's the bug. You'll see in the Group object that some attributes are defined as { force_scroll: undefined }. Having a value of a field be undefined won't drop the entire key/value entry out.

[Wilsonl9]

@kelvinjue Hmm, thats pretty odd. Normally, doesnt undefined get left out of the objects? in this case, they are actually overwriting the values with undefined?

Yup, that's the bug. You'll see in the Group object that some attributes are defined as { force_scroll: undefined }. Having a value of a field be undefined won't drop the entire key/value entry out.

ahh wait, I think it got it mixed up with mongo where undefined wouldnt be saved? I think this makes sense 👍

[Wilsonl9]

Something else I am curious about, by doing this, users would not be able to overwrite and "clear" their group settings. Is that something we should be worried about?

[kelvinjue]

Something else I am curious about, by doing this, users would not be able to overwrite and "clear" their group settings. Is that something we should be worried about?

I'm not sure I understand the case here. If a prop is passed in as undefined or not passed in at all, then we wouldn't send anything back to the group, and it'd fallback onto the defaults configured in our setup assistant. This bug happens because of properties being overwritten and putting the group in a bad state.

[Wilsonl9]

LGTM, nice find!