Fix lint #59
Merged
Fix lint #59
+28
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smckinney1
approved these changes
Sep 20, 2022
mewelling
reviewed
Sep 20, 2022
| @@ -19,6 +19,10 @@ class Demo extends React.Component { | |||
| }; | |||
| } | |||
|
|
|||
| static onEventMethod = (name, ...args) => { | |||
There was a problem hiding this comment.
oooo. what are the implications of using a static here? i dont think i've seen us use this here before
There was a problem hiding this comment.
We did this for the class-methods-use-this line rule. Since we don't reference this within the method—the rule asks us to make the method static—which makes sense in this context as it's more of a helper/utility method.
mewelling
reviewed
Sep 20, 2022
mewelling
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After upgrading some of our dependencies, issues with our lint rules or code were exposed.
Acceptance Criteria
Running
npm run test && lintshould pass without error.Note IRON-12855.