Add customData and acceptanceLanguage Props #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This brings the ability to add custom data to acceptance events with a new
customDataprop. Additionally, you can now set the acceptance language (using a newacceptanceLanguageprop) that gets displayed as part of your clickwrap group. Note: setting acceptance language requires the group to be dynamic.Testing
Unit tests should cover making sure the props get set correctly. But, to test locally, you should:
customDatato an object (e.g.,{key_1: "test", key_2: 3}) and trigger an acceptance. With this acceptance, if you go to the Clickwrap UI and view the acceptance event, you should see the custom data details in the right panel.acceptanceLanguageprop to a string and load the clickwrap in a test environment. In the loaded environment, you should see the acceptance language be presented.