Skip to content

Commit

Permalink
Merge pull request #133 from pactflow/fix-broken-build-due-to-env-var
Browse files Browse the repository at this point in the history
fix: simplify PACT_PROVIDER env variable
  • Loading branch information
mefellows authored Oct 17, 2023
2 parents c24934d + 88d8131 commit 5cfd654
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

env:
PACT_BROKER_BASE_URL: ${{ secrets.PACT_BROKER_BASE_URL }}
PACT_PROVIDER: ${{ env.PACT_PROVIDER }}
PACT_PROVIDER: pactflow-example-provider
PACT_BROKER_TOKEN: ${{ secrets.PACTFLOW_TOKEN_FOR_CI_CD_WORKSHOP }}
REACT_APP_API_BASE_URL: http://localhost:3001
GIT_COMMIT: ${{ github.sha }}
Expand All @@ -15,14 +15,6 @@ env:
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
pact_provider: [
# "pactflow-example-bi-directional-provider-dredd",
# "pactflow-example-bi-directional-provider-restassured",
# "pactflow-example-bi-directional-provider-postman",
'pactflow-example-provider'
]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand All @@ -32,12 +24,12 @@ jobs:
run: npm i
- name: Test
env:
PACT_PROVIDER: ${{ matrix.pact_provider }}
PACT_PROVIDER: ${{ env.PACT_PROVIDER }}
run: make test
- name: Publish pacts between pactflow-example-consumer and ${{ matrix.pact_provider }}
- name: Publish pacts between pactflow-example-consumer and ${{ env.PACT_PROVIDER }}
run: GIT_BRANCH=${GIT_REF:11} make publish_pacts
env:
PACT_PROVIDER: ${{ matrix.pact_provider }}
PACT_PROVIDER: ${{ env.PACT_PROVIDER }}

# Runs on branches as well, so we know the status of our PRs
can-i-deploy:
Expand Down

0 comments on commit 5cfd654

Please sign in to comment.