Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use SemanticLogger for Padrino #662

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

bethesque
Copy link
Member

@bethesque bethesque commented Jan 18, 2024

Prior to this PR, any errors raised in the UI get printed without formatting to stdout. This PR configures Padrino to use Semantic Logger, so that it respects the PACT_BROKER_LOG_FORMAT configuration (ie. it will print error logs in JSON).

This change is irrelevant to PF, as we don't use the server side rendered UI.

@bethesque bethesque requested a review from vwong January 18, 2024 01:46
@bethesque bethesque merged commit 5d9d700 into master Jan 23, 2024
17 checks passed
@bethesque bethesque deleted the chore/use-semantic-logger-for-padrino branch January 23, 2024 03:03
bethesque added a commit that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant