Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bulk delete branches #652

Merged
merged 3 commits into from
Dec 11, 2023
Merged

feat: bulk delete branches #652

merged 3 commits into from
Dec 11, 2023

Conversation

bethesque
Copy link
Member

No description provided.

@bethesque bethesque linked an issue Dec 8, 2023 that may be closed by this pull request
@bethesque bethesque requested review from vwong and tuan-pham December 8, 2023 00:22
Copy link
Contributor

@vwong vwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Question: Do we have any other code that behaves like this? Ie, do the action after an immediate response?

How would the API indicate completeness? Maybe the response should return a URL that the consumer can query to check on complete-ness?

@bethesque
Copy link
Member Author

Do we have any other code that behaves like this? Ie, do the action after an immediate response?

This is the first. I'm doing it this way because I know we've had problems in the past with performance when deleting large number of things.

Maybe the response should return a URL that the consumer can query to check on complete-ness?

You make a very good suggestion, but I'm not willing to do that amount of work for a feature that will be used maybe once per installation. If it was a key feature that would be commonly used, then yes, that would be the ideal pattern.

The idea is for the customer to use branch-merge or branch-deletion events in their SCM to clean up the deleted branches as they go using the individual branch delete endpoint. Calling this batch endpoint would be a once off task to clean up all the previously deleted branches.

@bethesque bethesque merged commit 14ac33c into master Dec 11, 2023
17 checks passed
@bethesque bethesque deleted the feat/bulk-delete-branches branch December 11, 2023 01:05
bethesque added a commit that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support bulk deletion of branches
2 participants