Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhooks): allow auth headers to be logged for debugging purposes #575

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

bethesque
Copy link
Member

With redaction

App logs

2022-10-07 10:35:51.905153 D [80210:worker-1] PactBroker::Webhooks::WebhookRequestLogger -- 
Webhook 7a5da39c-8e50-4cc9-ae16-dfa5be043e8c request 
headers={"accept"=>["*/*"], "user-agent"=>["Pact Broker v2.104.0"], "authorization"=>["**********"], 
"host"=>["postman-echo.com"], "content-length"=>["499"], "content-type"=>["application/x-www-form-urlencoded"]}

Logs returned via API

Screen Shot 2022-10-07 at 10 50 07 am

With redaction disabled

App logs

2022-10-07 10:51:28.802115 D [82363:worker-1] PactBroker::Webhooks::WebhookRequestLogger --
Webhook 7a5da39c-8e50-4cc9-ae16-dfa5be043e8c request
headers={"accept"=>["/"], "user-agent"=>["Pact Broker v2.104.0"], "authorization"=>["Basic dXNlcjpwYXNz"],
"host"=>["postman-echo.com"], "content-length"=>["499"], "content-type"=>["application/x-www-form-urlencoded"]}

Logs returned via API

Screen Shot 2022-10-07 at 10 51 51 am

@bethesque bethesque merged commit 102b193 into master Oct 7, 2022
@bethesque bethesque deleted the chore/support-disabling-header-redaction branch October 7, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant