fix(cleanup): Improve delete orphans SQL query #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barthez
force-pushed
the
improve-clean-incrementail-orphan-deletion
branch
2 times, most recently
from
4ade8ff to
87ce772
Compare
Original query to delete orphans was terribly slow and was unable to finish within default 15s timeout. Instead of excluding all ids from union, we left join all 3 tables and select only rows that have no joined values in pact_publications or verifications. Additionaly, the query was fixed for mysql. Whenever the Mysql error occures instead of embedded query, ids are fetched and then directly used in delete query.
barthez
force-pushed
the
improve-clean-incrementail-orphan-deletion
branch
from
87ce772 to
8e7e111
Compare
|
You're a champion. Thank you so much. I'd fixed one of these super inefficient queries, but hadn't gotten around to doing the rest. Sorry about the broken build on master - it's been SUCH a week! |
|
I've put out a new release with this PR. |
|
@barthez would you mind accepting my connection request on LinkedIn? I'd love to have a chat! |
|
I need to revert this PR because I believe it has caused the following errors in our clean logs. There was obviously some scenario not covered in the tests. I'll try and have a look into it, but not sure when that will be yet. |
bethesque
added a commit
that referenced
this pull request
Dec 2, 2021
bethesque
pushed a commit
that referenced
this pull request
Dec 2, 2021
* fix(cleanup): Improve delete orphans SQL query Original query to delete orphans was terribly slow and was unable to finish within default 15s timeout. Instead of excluding all ids from union, we left join all 3 tables and select only rows that have no joined values in pact_publications or verifications. Additionaly, the query was fixed for mysql. Whenever the Mysql error occures instead of embedded query, ids are fetched and then directly used in delete query. * fix: Add sql_enable_caller_logging documentation * fix: Fix unreliable spec
bethesque
added a commit
that referenced
this pull request
Dec 2, 2021
* fix(cleanup): Improve delete orphans SQL query (#527) * fix(cleanup): Improve delete orphans SQL query Original query to delete orphans was terribly slow and was unable to finish within default 15s timeout. Instead of excluding all ids from union, we left join all 3 tables and select only rows that have no joined values in pact_publications or verifications. Additionaly, the query was fixed for mysql. Whenever the Mysql error occures instead of embedded query, ids are fetched and then directly used in delete query. * fix: Add sql_enable_caller_logging documentation * fix: Fix unreliable spec * fix: fully qualify pact_version table joins in database clean Co-authored-by: Bartek Bułat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original query to delete orphans was terribly slow and was unable to finish within default 15s timeout. Instead of excluding all ids from union, we left join all 3 tables and select only rows that have no joined values in
pact_publicationsor verifications.Additionaly, the query was fixed for mysql. Whenever the Mysql error occures instead of embedded query, ids are fetched and then directly used in delete query.
[edit]
Added
sql_enable_caller_loggingconfiguration documentation as it was causing specs failures.