Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deployments and releases #426

Merged
merged 16 commits into from
May 10, 2021

Conversation

bethesque
Copy link
Member

@bethesque bethesque commented May 1, 2021

TODO

  • record undeployed
  • record unsupported
  • add deployed version resource
  • policy_record_params and policy_record
  • released versions for version resource
  • add support for currentlyReleased: true selector

@bethesque bethesque marked this pull request as draft May 1, 2021 06:41
@bethesque bethesque changed the title feat: support multiple instances of an application being deployed to the same environment at once feat: support deployments and releases May 3, 2021
@bethesque bethesque requested review from uglyog and mefellows May 10, 2021 01:25
@bethesque
Copy link
Member Author

As per https://docs.pact.io/pact_broker/recording_deployments_and_releases/

This PR allows us to differentiate between releases and deployments, and allows multiple instances of a particular application to be deployed in the same environment at a time (differentiated by the deployment "target"). The key difference between a release and a deployment is that a deployment automatically marks the previous deployed version as undeployed, where as a release does not.

Still to do is the record-undeployment and record-support-ended, but this can be merged now.

Copy link
Member

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@bethesque bethesque marked this pull request as ready for review May 10, 2021 01:31
@bethesque bethesque merged commit 58d173d into master May 10, 2021
@bethesque bethesque deleted the feat/add-deployed-version-instance branch May 10, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants