-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support recording deployments #389
Conversation
… and matrix endpoints
… together to query the matrix
@@ -34,6 +33,10 @@ def self.find_by_name(name) | |||
def self.delete(uuid) | |||
PactBroker::Deployments::Environment.where(uuid: uuid).delete | |||
end | |||
|
|||
def self.find_for_pacticipant(pacticipant) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not using the pacticipant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted - that's a dummy method for Pactflow to override by supplying a different service. In the OSS version, any pacticipant can deploy to any environment (mostly because I don't want to have to develop a configuration page 😆 ), but in Pactflow, I envisage us supporting assigning particular environments to pacticipants.
… the versions" in an environment in the matrix explanation messages
I didn't look at the code Beth, but I can agree that this is awesomeness. |
It's ok, Ron's got the 🦅 eyes. Just wanted to get you across the upcoming features. |
can-i-deploy
with an environment namepact-broker can-i-deploy --pacticipant Foo --version 1 --to-environment test
pact-broker record-deployment --pacticipant Foo --version 1 --environment test
(not yet written).pb:record-deployment
relation with the matching environment name).{ replacedPreviousDeployedVersion: true }
with the "record deployment" post request, and the previous deployed version will be marked as undeployed in the broker.--no-replace-previous-deployed-version
is specified in the CLI, the call to record the deployment will specify{ replacedPreviousDeployedVersion: false }
and the previous deployed version will not be marked as undeployed.Next