feat: Follow up for #239 + adding list of success codes to SAVABLE_SETTING_NAMES variable #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: 'webhook_http_code_success' should be printed out too for logging/diagnosis
pitschr
changed the title
|
Good pick up. I'm a poor reviewer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During developing for pact-broker-docker I noticed that the http-code checking is still not working, I noticed that I only fixed the "logging" part but not the real code check. 😆 It should now also be fixed and I added some test cases.
Furthermore I also added 'webhook_http_code_success' to the SAVABLE_SETTING_NAMES so that the configured value is also printed during pact-broker-docker startup.