-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy to clipboard #283
Copy to clipboard #283
Conversation
This looks good! Can you see if you can fix whatever code climate is complaining about? |
Tested on
|
Love the gif! What did you use to make it? |
Many thanks @tancnle! |
@bethesque I'd just learnt to do it as part of this PR :)
brew install ffmpeg
ffmpeg -i copy-to-clipboard.mov copy-to-clipboard.gif |
@tancnle reckon you can fix the cell resize that happens when the sha is fully taking up the column and the icon appears? |
PS. Super fun making the gif! |
@bethesque Yes certainly can |
This is getting a little bit trickier than I thought. There are few options:
Any preferences @bethesque? |
Could you always include the icon, but style it as hidden until the mouseover event happens? |
Description
A working proof-of-concept for 'Copy to clipboard' functionality in index and matrix page.
I was tossing around whether to go with third party libraries like
For our use cases, I decided to start with this simple gist and wired the markup a-la-carte. I am open up to more discussion on whether this is a sensible approach.
Demo
This closes #211