chore: use pact_version_sha instead of pact_version_id in index item …

…- revert to it's previous logic
pact-foundation · May 26, 2018 · c94a992 · c94a992
1 parent 13b7c6e
commit c94a992
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/pact_broker/domain/index_item.rb b/lib/pact_broker/domain/index_item.rb
@@ -102,7 +102,7 @@ def latest_verification_successful?
       end
 
       def pact_changed_since_last_verification?
-        latest_verification.pact_version_id != latest_pact.pact_version_id
+        latest_verification.pact_version_sha != latest_pact.pact_version_sha
       end
 
       def latest_verification_provider_version_number

diff --git a/lib/pact_broker/index/service.rb b/lib/pact_broker/index/service.rb
@@ -32,7 +32,7 @@ def self.find_index_items options = {}
         rows = rows.all.group_by(&:pact_publication_id).values.collect{ | rows| Matrix::AggregatedRow.new(rows) }
 
         rows.sort.collect do | row |
-          # TODO simplify
+          # TODO simplify. Do we really need 3 layers of abstraction?
           PactBroker::Domain::IndexItem.create(
             row.consumer,
             row.provider,