Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add participant label options to webhook create/update commands #96

Merged
merged 1 commit into from
Oct 6, 2021
Merged

feat: Add participant label options to webhook create/update commands #96

merged 1 commit into from
Oct 6, 2021

Conversation

rabotyaga
Copy link
Contributor

Add --consumer-label and --provider-label options to webhook create/update commands.
Related to pact-foundation/pact_broker#501

@rabotyaga rabotyaga changed the title Add participant label options to webhook create/update commands feat: Add participant label options to webhook create/update commands Oct 5, 2021
@rabotyaga rabotyaga force-pushed the add-participant-labels-to-webhook-commands branch from f908268 to 85d6ceb Compare October 5, 2021 14:31
bethesque
bethesque requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@bethesque bethesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When you've made that last change, can you squash and use a semantic commit to make the semantic commit checker pass? We can ignore the appveyor one. I should just delete that.

spec/service_providers/webhooks_create_spec.rb Outdated Show resolved Hide resolved
@rabotyaga rabotyaga force-pushed the add-participant-labels-to-webhook-commands branch from 85d6ceb to b689da9 Compare October 6, 2021 06:47
@rabotyaga rabotyaga requested a review from bethesque October 6, 2021 06:48
@rabotyaga rabotyaga force-pushed the add-participant-labels-to-webhook-commands branch from b689da9 to 691e30d Compare October 6, 2021 08:53
@rabotyaga rabotyaga requested a review from bethesque October 6, 2021 08:54
@bethesque
Copy link
Member

Perfect! Thanks.

@bethesque bethesque merged commit 710293f into pact-foundation:master Oct 6, 2021
@rabotyaga rabotyaga deleted the add-participant-labels-to-webhook-commands branch October 6, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethesque bethesque Awaiting requested review from bethesque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabotyaga @bethesque