Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ffi): deprecate pactffi_with_binary_file #457

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

JP-Ellis
Copy link
Contributor

The pactffi_with_binary_file is functionally replaced by the combination of pactffi_with_binary_body and
pactffi_with_matching_ruless. These two functions should be preferred over this one.

Furthermore, this function's naming (especially when compared to pactffi_with_binary_body) which might suggest it merely sets the body by reading a specific binary file.

The `pactffi_with_binary_file` is functionally replaced by the
combination of `pactffi_with_binary_body` and
`pactffi_with_matching_ruless`. These two functions should be preferred
over this one.

Furthermore, this function's naming (especially when compared to
`pactffi_with_binary_body`) which might suggest it merely sets the body
by reading a specific binary file.

Signed-off-by: JP-Ellis <[email protected]>
@JP-Ellis JP-Ellis requested a review from rholshausen July 17, 2024 03:18
@JP-Ellis JP-Ellis self-assigned this Jul 17, 2024
@JP-Ellis JP-Ellis merged commit 51c6cb0 into master Jul 17, 2024
63 checks passed
@JP-Ellis JP-Ellis deleted the chore/deprecate-with-binary-file branch July 17, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants