Feat/smaller binaries #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[profile.release] strip = true opt-level = "z" codegen-units = 1 we do not use lto=true, as this config is applied at the root level to both the pact_ffi and verifier_cli crates. lto=true inflates the size of the static libraries dramatically. It may be prudent to apply this in the release scripts for the verifier cli to allow for further executable size reductions. Should we elect for setting these values conditionally or via a seperate profile, such that we dont affect the --release profile for other crates in the workspace?
YOU54F
force-pushed
the
feat/smaller_binaries
branch
from
8dcea0b
to
29359fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slim executables as per
we do not use
lto=true, as this config is applied at the root level to both thepact_ffiandverifier_clicrates.lto=trueinflates the size of the static libraries dramatically generated by \pact_ffi`.It may be prudent to apply these additional
RUSTFLAGSin the release scripts for the verifier cli to allow for further executable size reductions.Question
Testing
Have been testing in this draft PR against my forks, which are all working as expected however it uncovered an issue in one of pact-net's test against the current released 0.4.20 version (more detail in the pr draft) - I've still to yak shave that one but it's not relevant to this PR
YOU54F#6