Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip ANSI escapes from JUnit output #426

Merged

Conversation

mjpieters
Copy link
Contributor

When coloured output is enabled, output strings contain ANSI escapes, sequences of binary data that communicate with a terminal to control colours. Remove these sequences when producing a JUnit report, because the ESC bytecode (0x1B) is not a valid codepoint in XML documents.

Fixes #421

When coloured output is enabled, output strings contain ANSI escapes,
sequences of binary data that communicate with a terminal to control
colours. Remove these sequences when producing a JUnit report, because
the ESC bytecode (0x1B) is not a valid codepoint in XML documents.
@rholshausen rholshausen merged commit aa98f99 into pact-foundation:master May 30, 2024
15 of 18 checks passed
@mjpieters mjpieters deleted the 421-strip-ansi-escapes branch May 31, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verifier CLI: junit output contains invalid characters.
2 participants