Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CONTRIBUTING.md): update installation steps #687

Merged

Conversation

qmg-drettie
Copy link
Contributor

@qmg-drettie qmg-drettie commented May 2, 2024

adds step to patch the compatibility suite in order for tests to pass

✈️ Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

📝 Summary

adds step to patch the compatibility suite in order for tests to pass

🚨 Breaking Changes

🔥 Motivation

Cloned the repo for the first time and tried to run tests but some are failing. I found that the patch command is running within the github actions workflow to make the tests pass.

🔨 Test Plan

🔗 Related issues/PRs

adds step to patch the compatibility suite in order for tests to pass
@JP-Ellis
Copy link
Contributor

JP-Ellis commented May 2, 2024

Thanks! It was entirely an oversight on my part. The patch is temporary and will eventually be merged upstream; however, until such time, it is definitely better to make sure the docs are up to date!

@JP-Ellis JP-Ellis enabled auto-merge (rebase) May 2, 2024 23:47
@JP-Ellis JP-Ellis merged commit 32b5cfe into pact-foundation:master May 2, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants