Chore/more wheel fixes #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that the wheels generated are compatible with as many devices as possible, I am pinning the operating systems of the runners to the oldest version currently supported. Signed-off-by: JP-Ellis <[email protected]>
To avoid ambiguity, setting the macOS deployment target explicitly. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
added
difficulty:easy
JP-Ellis
force-pushed
the
chore/more-wheel-fixes
branch
2 times, most recently
from
25579d2
to
f6066ed
Compare
Install hatch on the PyPy images seems unnecessarily difficult, just to run a few `rm` commands. So I am replacing the before-build step with the required `rm` commands. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/more-wheel-fixes
branch
2 times, most recently
from
7c32e83
to
228dfa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
A combination of a few additional fixes:
chore(ci): replace hatch clean with rm (228dfa7)
Install hatch on the PyPy images seems unnecessarily difficult, just to run a
few
rmcommands. So I am replacing the before-build step with the requiredrmcommands.chore(ci): set osx deployment target (5085931)
To avoid ambiguity, setting the macOS deployment target explicitly.
chore(ci): pin os to older versions (325f731)
To ensure that the wheels generated are compatible with as many devices as
possible, I am pinning the operating systems of the runners to the oldest
version currently supported.
🚨 Breaking Changes🔥 Motivation
Ensuring greater compatibility, and fixing the PyPy builds.
🔨 Test Plan
In CI
🔗 Related issues/PRs
None