chore(ci): fix pypy before-build #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust needs to be manually installed within the pypy build image; however, with the addition of `before-build`, it would appear that the existing `before-build` no longer works. The installation of the Rust toolchain has been moved to the `before-all` step. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/fix-pypy-wheel-build
branch
2 times, most recently
from
a240025
to
bce009b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Rust needs to be manually installed within the pypy build image; however, with the addition of
before-build, it would appear that the existingbefore-buildno longer works.The installation of the Rust toolchain has been moved to the
before-allstep.🚨 Breaking Changes🔥 Motivation
Fix the PyPy wheels.
🔨 Test Plan
CI
🔗 Related issues/PRs
None