Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add future deprecation warnings #398

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

JP-Ellis
Copy link
Contributor

@JP-Ellis JP-Ellis commented Sep 27, 2023

📝 Summary

As work starts on the next major version of Pact for Python, we need to start warning users that the current version will be deprecated in the future.

This commit adds a warning to the top of all modules and standalone functions informing end-users of a major upstream change. While the class names themselves might remain, the way they are used may change to accommodate the changes brought by the move to the Pact reference library, and to accommodate versions 3 and 4 of the Pact specification.

Once the work on Pact Python v3 is complete, a thorough migration guide will be written and only those classes, methods and functions which are breaking will have a DeprecationWarning added.

🚨 Breaking Changes

🔨 Test Plan

Not Applicable

🔗 Related issues/PRs

As work starts on the next major version of Pact for Python, we need to
start warning users that the current version will be deprecated in the
future.

This commit adds a warning to the top of all modules and standalone
functions that will be deprecated in the next major version. While the
class names themselves might remain, the way they are used may change to
accommodate the changes in the underlying workings, and to accommodate
versions 3 and 4 of the Pact specification.

Once the work on the Pact Python v3 is complete, a thorough migration
guide will be written.

Signed-off-by: JP-Ellis <[email protected]>
@JP-Ellis JP-Ellis self-assigned this Sep 27, 2023
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment about the link text but otherwise happy for this go

@JP-Ellis JP-Ellis merged commit 9fe9694 into master Oct 3, 2023
27 of 29 checks passed
@JP-Ellis JP-Ellis deleted the chore/pending-deprecation-warning branch October 3, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Completed
Development

Successfully merging this pull request may close these issues.

Add PendingDeprecationWarning to the existing library
2 participants