Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect link to contributing guidelines #592

Closed
2 of 4 tasks
samueljsb opened this issue Mar 6, 2024 · 0 comments · Fixed by #594
Closed
2 of 4 tasks

Incorrect link to contributing guidelines #592

samueljsb opened this issue Mar 6, 2024 · 0 comments · Fixed by #594

Comments

@samueljsb
Copy link

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of pact-python.
  • I have read the console error message carefully (if applicable).

Description

The link to the Contributing Guidelines on issues in this template points to a page that does not exist.

I think the link should be https://github.com/pact-foundation/pact-python/blob/master/CONTRIBUTING.md#issues.

Reproducible demo

No response

Steps to reproduce

Click the link above

Expected behavior

The contributing guidelines are shown

Actual behavior

Not Found

Your environment

N/A

Self-service

  • I'd be willing to fix this bug myself.
JP-Ellis added a commit that referenced this issue Mar 6, 2024
@JP-Ellis
docs: fix links to CONTRIBUTING.md
9be091b 
A few of the `CONTRIBUTING.md` link were invalid, either due to
referring to the `main` branch instead of `master`, or missing the
`/blob/` segment in the path.

Resolves: #592
Signed-off-by: JP-Ellis <[email protected]>
@JP-Ellis JP-Ellis mentioned this issue Mar 6, 2024
Merged
JP-Ellis added a commit that referenced this issue Mar 6, 2024
@JP-Ellis
docs: fix links to CONTRIBUTING.md
eb8e91d 
A few of the `CONTRIBUTING.md` link were invalid, either due to
referring to the `main` branch instead of `master`, or missing the
`/blob/` segment in the path.

Resolves: #592
Signed-off-by: JP-Ellis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix links to CONTRIBUTING.md pact-foundation/pact-python
1 participant
@samueljsb