Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter factory method #599

Merged
merged 3 commits into from
May 11, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented May 5, 2024

Depend on:

Apply Bridge and Factory Method design patterns to refactor formatters

Here is the full diagram:

matchers-formatters

@tienvx tienvx force-pushed the formatter-factory-method branch from f68181d to e1d075b Compare May 5, 2024 14:38
@tienvx tienvx marked this pull request as ready for review May 5, 2024 16:02
@tienvx tienvx requested a review from mefellows May 5, 2024 16:03
@YOU54F
Copy link
Member

YOU54F commented May 10, 2024

Nice change! It's a biggie so appreciate you splitting out the two PR's prior, as it helped me focus on them.

I'm looking at the end user interface changes in the examples, and that looks make it easier (removing an import and having as a option), considering your touched ~140 files, have minimal changes in your tests and everything green makes me a very confident person.

Appreciate the diagram!

So in a nutshell does this make it easier to maintainers/contributors to maintain/extend these interfaces in future? Whats the big selling point of moving to the new pattern.

Looks good to me though, haven't ran it locally but he have 💚 ci

@tienvx
Copy link
Contributor Author

tienvx commented May 10, 2024

So in a nutshell does this make it easier to maintainers/contributors to maintain/extend these interfaces in future?

Yes, you are correct. This is the whole point of this PR.

@tienvx
Copy link
Contributor Author

tienvx commented May 11, 2024

Self-reviewed

@tienvx tienvx merged commit e07f7a1 into pact-foundation:master May 11, 2024
26 checks passed
@tienvx tienvx deleted the formatter-factory-method branch May 11, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants