Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Assert json encoded value is string #573

Merged
merged 1 commit into from
Apr 26, 2024
Merged

chore: Assert json encoded value is string #573

merged 1 commit into from
Apr 26, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Apr 25, 2024

Fix errors like this:

Parameter #2 $actualJson of method                                            
         PHPUnit\Framework\Assert::assertJsonStringEqualsJsonString() expects string,  
         string|false given.

For #564

@tienvx tienvx requested a review from JP-Ellis April 25, 2024 16:49
@tienvx tienvx merged commit 267d3d7 into pact-foundation:master Apr 26, 2024
26 checks passed
@tienvx tienvx deleted the assert-is-string branch April 26, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @JP-Ellis