Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Reuse process handling code #451

Merged
merged 1 commit into from
Jan 24, 2024
Merged

chore: Reuse process handling code #451

merged 1 commit into from
Jan 24, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Jan 23, 2024

  • Rename ProviderProcess to AbstractProcess to reuse code
  • Add PhpProcess
  • Add RoadRunnerProcess
  • Use dynamic port for PhpProcess

@tienvx tienvx mentioned this pull request Jan 24, 2024
Closed
Lewiscowles1986
Lewiscowles1986 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@Lewiscowles1986 Lewiscowles1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sockets are one of the first things I look for as a warning, but this simplifies the calling to be in one place. Nice one @tienvx

@tienvx tienvx merged commit 6933622 into pact-foundation:ffi Jan 24, 2024
24 of 30 checks passed
@tienvx tienvx deleted the reuse-process branch January 24, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lewiscowles1986 Lewiscowles1986 Lewiscowles1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @Lewiscowles1986