Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add RandomInt generator class #376

Merged
merged 1 commit into from
Dec 11, 2023
Merged

refactor: Add RandomInt generator class #376

merged 1 commit into from
Dec 11, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 8, 2023

@tienvx tienvx force-pushed the add-random-int-generator-class branch from 971d7ce to cdc9bc6 Compare December 8, 2023 14:59
@tienvx tienvx mentioned this pull request Dec 8, 2023
Merged
@Lewiscowles1986
Copy link
Collaborator

I like this, the value-type makes it harder to make mistakes. Big win

@tienvx
Copy link
Contributor Author

tienvx commented Dec 11, 2023

Thank you!

@tienvx tienvx merged commit 93caeb8 into pact-foundation:ffi Dec 11, 2023
26 checks passed
@tienvx tienvx deleted the add-random-int-generator-class branch December 11, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lewiscowles1986 Lewiscowles1986 Lewiscowles1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @Lewiscowles1986