feat: allow multi values for regex matcher #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as Draft, because I need to test with compatibility suite first. PHP has 2 different behaviors when it come to the multiple values for query parameter. |
tienvx
force-pushed
the
allow-multi-values-regex-matcher
branch
from
0330fcb
to
9f13937
Compare
tienvx
force-pushed
the
allow-multi-values-regex-matcher
branch
from
9f13937
to
c19dca8
Compare
|
Marked as ready. I tested with compatibility suite and it works fine. |
YOU54F
approved these changes
Nov 3, 2023
|
Looks like we've ran out of credits on cirrus-ci post changes to their pricing models https://cirrus-ci.org/blog/2023/07/17/limiting-free-usage-of-cirrus-ci/ so we can ignore the failing cirrus-ci tasks for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allow to use
regexmatcher to match multiple values for query parameter and header. See pact-foundation/pact-reference#332This feature is mostly for compatibility suite, in v2/http_consumer feature, with these scenarios: