-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rust FFI #10: Remove pact broker #302
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2023
tienvx
force-pushed
the
remove-pact-broker
branch
2 times, most recently
from
March 16, 2023 04:06
dd90f88
to
affb5cd
Compare
tienvx
force-pushed
the
remove-pact-broker
branch
2 times, most recently
from
March 21, 2023 05:15
db57b54
to
d74d9b3
Compare
…ecause implementation throws it
tienvx
force-pushed
the
remove-pact-broker
branch
2 times, most recently
from
May 8, 2023 16:27
4d2b1fc
to
28128fc
Compare
tienvx
force-pushed
the
remove-pact-broker
branch
from
May 10, 2023 04:40
d5cbff6
to
c1a74f5
Compare
@YOU54F thanks for the idea. I will take it into account when this PR is being reviewed. |
tienvx
force-pushed
the
remove-pact-broker
branch
from
May 12, 2023 06:46
c1a74f5
to
e401847
Compare
12 tasks
Close as there will be a PR from |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follow suggestion from @mefellows that:
One of the reason is: The Ruby Standalone has windows long file path and not working on a bunch of OS/Arch combinations. So bundling it into Pact PHP will mean Pact PHP won’t be installable on those same systems
@mefellows will give further explanation if needed.
I think this suggestion make sense because:
For Github Actions it's quite easy to add a step to publish pacts while still follow other recommendation (like include commit SHA in the version, use branch instead of tag):
This PR depend on #284. Please review it first.