-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow PSR-2 codingsstandards #12
Comments
I'm game. I have a separate request to follow PSR-3 but no pull requests yet. I do not have major fixes in the works yet. I'm starting to work on v2. That said, with such a large refactor as you mentioned, we really need AppVeyor running on pull requests |
BTW, Why are you using AppVeyor? If it's hard to set up on pull requests we could use Travis? |
As I mentioned, Windows is my primary concern and AppVeyor does a good job at that. AppVeyor should be setup appropriately now. |
I'm going to see if I can pull this off today. |
This was a great idea. I plugged php-cs-fixer into AppVeyor. Merged to master but not re-tagged |
Nice! |
Sorry to say, but on some places, the code is really a mess.
It would be great if we could follow the PSR-2 standard.
We can even automatically fix the current code with https://github.com/friendsofphp/php-cs-fixer
If no big refactors are happening right now, I can try to run it and create a PR for it? It needs to be merged fast because it will be annoying for others that are working on improvements and having to rebase.
The text was updated successfully, but these errors were encountered: