-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(TypeScript) Cannot use V3 matchers within MessagePact. Types are incompatible. #1133
Closed
3 tasks done
murbanowicz opened this issue
Oct 26, 2023
· 3 comments
· Fixed by pact-foundation/pact-js-core#493 or #1183
Closed
3 tasks done
(TypeScript) Cannot use V3 matchers within MessagePact. Types are incompatible. #1133
murbanowicz opened this issue
Oct 26, 2023
· 3 comments
· Fixed by pact-foundation/pact-js-core#493 or #1183
Comments
murbanowicz
added
bug
Indicates an unexpected problem or unintended behavior
triage
This issue is yet to be triaged by a maintainer
labels
Oct 26, 2023
This should be fixed now in the latest release. |
@mefellows Which version of pact-js do you consider to contain the fix? With 12.1.2 (running on Windows) the problem still seems to exist. |
The fix addressed the main body but not the matchers, which I believe is what you need. It should be straightforward, I'll see if I can patch it tomorrow for you |
mefellows
added a commit
to pact-foundation/pact-js-core
that referenced
this issue
Feb 27, 2024
Supports metadata with matching rules Fixes pact-foundation/pact-js#1133 Fixes pact-foundation/pact-js#745
mefellows
added a commit
to pact-foundation/pact-js-core
that referenced
this issue
Feb 28, 2024
Supports metadata with matching rules Fixes pact-foundation/pact-js#1133 Fixes pact-foundation/pact-js#745
mefellows
added a commit
that referenced
this issue
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Software versions
TypeScript: 5.2.2
"@pact-foundation/pact": "12.1.0"
Issue Checklist
Please confirm the following:
Expected behaviour
I should be able to use v3 matchers
Actual behaviour
Types are incompatible
Steps to reproduce
gives the following error:
It will only work without error when using
Matchers
which I believe are V2 matches and are missing quite a lot of stuff.Relevant log files
Please ensure you set logging to
DEBUG
and attach any relevant log files here (or link to a gist).The text was updated successfully, but these errors were encountered: