Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo for Roadmap link #48

Merged
merged 1 commit into from
Sep 30, 2017
Merged

Conversation

rafaelhdr
Copy link
Contributor

@mefellows
Copy link
Member

Thanks @rafaelhdr, the change looks good. Could you please update your commit message however as per https://github.com/pact-foundation/pact-go/blob/master/CONTRIBUTING.md ?

(I'd suggest in this case chore(docs): fix link to roadmap or similar).

We use the conventional changelog to create release documentation etc. which is why we're being strict (not just my OCD :) )

@rafaelhdr
Copy link
Contributor Author

Sorry and thanks for the instructions. Just fixed it :)

@mefellows mefellows merged commit 09ce895 into pact-foundation:master Sep 30, 2017
@mefellows
Copy link
Member

No worries and thanks!

@rafaelhdr rafaelhdr deleted the patch-1 branch September 30, 2017 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants