fix: plugin verification panics due to missing SA_ONSTACK signal #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #269
yak shave and a half, bit of a write up and repro in the pact reference repo
pact-foundation/pact-reference@master...YOU54F:pact-reference:issue/go_signals
tried building the ffi and csv plugin with musl 1.25, as 1.24 has a fix in it, similar to that referenced by Jason in the original issue for glibc.
that didnt seem to solve the issue for me
we cant move to that new a version of glibc as we need to be compatible with older distroes, and i haven’t tested that out to see if it works.
some links from the yak shave
cgo onstack failures
FYI https://git.musl-libc.org/cgit/musl/commit/?id=2e5fff43dd7fc808197744c67cca7908ac19bb4f switched musl to using the alt stack for internal signals and will be present in future releases starting with 1.2.4.
*-linux-musl
targets to musl 1.2 rust-lang/compiler-team#572note to self - if we can get this fix applied to purego project as well that would be ace, if not maybe adding the function into the pact_ffi lib so it could be called whether we are using cgo or not 🤔