Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase max size of pact output buffer #146

Merged

Conversation

cltatman
Copy link
Contributor

@cltatman cltatman commented Aug 7, 2020

by default, Scanner.Scan() halts for lines larger than MaxScanTokenSize (64kb). if a JSON document in pact's output is larger than this, scanning stops and stdout contents are discarded

this change allocates a 64kb buffer up front, but grows the buffer up to 64mb for larger output

Copy link
Member

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

The build is failing as there is a race. I thought I'd fixed it a while back. I've fixed it in another branch so will pull this in now.

@mefellows mefellows merged commit fcf9111 into pact-foundation:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants