Match should skip unexported fields as they won't be serialized (#201)

fix: match should skip unexported fields as they won't be serialized
pact-foundation · Feb 9, 2022 · 25a5ad5 · 25a5ad5
1 parent 2f6d45e
commit 25a5ad5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/dsl/matcher.go b/dsl/matcher.go
@@ -301,6 +301,10 @@ func match(srcType reflect.Type, params params) Matcher {
 
 		for i := 0; i < srcType.NumField(); i++ {
 			field := srcType.Field(i)
+			// Skip unexported fields.
+			if field.PkgPath != "" {
+				continue
+			}
 			fieldName := getJsonFieldName(field)
 			if fieldName == "" {
 				continue

diff --git a/dsl/matcher_test.go b/dsl/matcher_test.go
@@ -598,6 +598,9 @@ func TestMatch(t *testing.T) {
 		Word     string `json:"word"`
 		WordDash string `json:"-,"`
 	}
+	type unexportedDTO struct {
+		unexported string
+	}
 	str := "str"
 	type args struct {
 		src interface{}
@@ -752,6 +755,13 @@ func TestMatch(t *testing.T) {
 				"-":    Like("string"),
 			},
 		},
+		{
+			name: "recursive case - struct with unexported field",
+			args: args{
+				src: unexportedDTO{},
+			},
+			want: StructMatcher{},
+		},
 		{
 			name: "base case - string",
 			args: args{