Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct broken links and fail build on further broken links #122

Merged
merged 1 commit into from
Mar 26, 2022
Merged

fix: correct broken links and fail build on further broken links #122

merged 1 commit into from
Mar 26, 2022

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Mar 22, 2022

fixes #112

mefellows
mefellows approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. We should definitely have a guide for maintainers on this.

It's annoying that locally it all works, it's only on "build" that it fails. It would be more ideal that during the local running i.e. npm start it fails too.

@YOU54F
Copy link
Member Author

YOU54F commented Mar 25, 2022

nice. We should definitely have a guide for maintainers on this.

It's annoying that locally it all works, it's only on "build" that it fails. It would be more ideal that during the local running i.e. npm start it fails too.

I know it is annoying, there is a note in the docs stating it only works on production builds

https://docusaurus.io/docs/api/docusaurus-config#onbrokenlinks

What is interesting is for a similar option onDuplicateRoutes this check is available during start and build so we may be able to request a PR change

https://docusaurus.io/docs/api/docusaurus-config#onduplicateroutes

@YOU54F YOU54F mentioned this pull request Mar 25, 2022
Open
7 tasks
@YOU54F YOU54F merged commit b226cb4 into master Mar 26, 2022
@YOU54F YOU54F deleted the brokenLinks branch October 5, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mefellows mefellows mefellows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken links
2 participants
@YOU54F @mefellows