This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
fix: remove undefined variable in staticman.js #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
err
variable in the current Staticman JS script is undefined, as my correspondence with Ricardo Fusari reveals.Motivation and Context
The error-handling function with the
error
argument comes from jQuery'sajax()
method. Due to @pacollins' plan to remove jQuery from the dependencies, I submitted #245 to refactor the form submission using XHR objects.To log XHR errors, one may use
myXHRobj.addEventListener('error', handleEvent)
with custom JS functionhandleEvent()
. As far as I know, few users would interestInterested tech guys would find a way to get errors. Others might hardly need this
err
objectScreenshots (if appropriate):
[You can use
Windows+Shift+S
orControl+Command+Shift+4
to add a screenshot to your clipboard and then paste it here.]Checklist:
theme.toml
, as applicable.