Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge new setup into v1 branch #208

Merged
merged 18 commits into from
Aug 28, 2023
Merged

merge new setup into v1 branch #208

merged 18 commits into from
Aug 28, 2023

Conversation

trm217
Copy link
Collaborator

@trm217 trm217 commented Aug 28, 2023

Description

This PR contains:

  • merging the current main into v1 (which adds the new tooling / setup to the v1 branch.
  • slight addition to the types.ts comments
  • cleanup of the README.md
  • adding @types/node & @types/jest to the monorepo root to ensue correct linting in IDEs.
    (we could consider moving anything test related up to the monorepo root.

Caveats

git didn't catch some diffs between the two branches. I had two fix two things manually.
Perhaps there might be more, but in that case, I would've missed it…

pacocoursey and others added 13 commits May 22, 2022 10:46
Using `resolvedTheme` will cause the select to show `light` or `dark` when `system` is selected rather than `system` as expected.

Co-authored-by: Paco <[email protected]>
The previous documentation referred to using `<ThemeProvider defaultTheme="system">`, but this is no longer necessary
Every time <Theme /> renders a new object is constructed and passed to ThemeContext.Provider. This guarantees that regardless of what inputs changed the Context will be propagated. This is particularly harmful when React is doing hydration because if an unhydrated Suspense boudnary exists in the sub-tree of the Provider it will fall back to client rendering regardless of whether the context is an actual dependency for that Suspense boundary.

This commit adds memoization so the value only changes if one of it's inputs change
To make this memoization effective the default argument for `themes` needed to be statically extracted (it constructs a new array on each function invocation otherwise)
* chore: add .nvmrc

* chore: convert intor a turbo based monorepo (yarn workspaces)

* chore: start refactoring playwright tests

* chore: add missing scripts to 'example' package and update playwright config accordingly

* fix(example/tailwind): use class-attribute

* chore(actions): update node version and bump setup-node to v2

* chore: move license to repository-root
* port pr 178

* fix up logic
…nt (#202)

* cleanup package.json files

* prettier

* move tests to test/

* empty commit for vercel build

* empty commit for vercel build

* rename root package.json

* upgrade next.js and react in examples

* switch to pnpm monorepo, upgrade deps

* update github actions to use pnpm, add to packageManager

* use workspace dep

* update workflows to install pnpm

* back to npx

* many changes…

* empty commit for vercel build

* empty commit for vercel build

* empty commit for vercel build

* idk

* revert link changes, ready to merge
@trm217 trm217 self-assigned this Aug 28, 2023
@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-themes-basic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 6:43am
next-themes-tailwind ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 6:43am

@pacocoursey pacocoursey merged commit 108ac74 into v1 Aug 28, 2023
3 checks passed
@pacocoursey pacocoursey deleted the merge-new-setup-into-v1 branch August 28, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants