fix: useId backward compatibility #165
Merged
Annotations
5 errors, 3 warnings, and 1 notice
Run pnpm test || exit 1:
test/basic.test.ts#L26
1) [webkit] › basic.test.ts:23:7 › basic behavior › item onSelect is called on click ─────────────
Error: expect(received).toEqual(expected) // deep equality
Expected: "Item selected"
Received: "[HMR] connected"
24 | const item = page.locator(`[cmdk-item][data-value="Item"]`)
25 | const [message] = await Promise.all([page.waitForEvent('console'), item.click()])
> 26 | expect(message.text()).toEqual('Item selected')
| ^
27 | })
28 |
29 | test('first item is selected by default', async ({ page }) => {
at /home/runner/work/cmdk/cmdk/test/basic.test.ts:26:28
|
Run pnpm test || exit 1:
test/basic.test.ts#L1
2) [webkit] › basic.test.ts:66:7 › basic behavior › className is applied to each part ────────────
Test timeout of 5000ms exceeded.
|
Run pnpm test || exit 1:
test/basic.test.ts#L72
2) [webkit] › basic.test.ts:66:7 › basic behavior › className is applied to each part ────────────
Error: expect(locator).toHaveCount(expected)
Locator: locator('.item')
Expected: 0
Received: 2
Call log:
- expect.toHaveCount with timeout 5000ms
- waiting for locator('.item')
- locator resolved to 2 elements
- unexpected value "2"
- locator resolved to 2 elements
- unexpected value "2"
- locator resolved to 2 elements
- unexpected value "2"
- locator resolved to 2 elements
- unexpected value "2"
- locator resolved to 2 elements
- unexpected value "2"
- locator resolved to 2 elements
- unexpected value "2"
- locator resolved to 2 elements
- unexpected value "2"
- locator resolved to 2 elements
- unexpected value "2"
70 | await expect(page.locator(`.item`)).toHaveCount(2)
71 | await page.locator('[cmdk-input]').type('zzzz')
> 72 | await expect(page.locator(`.item`)).toHaveCount(0)
| ^
73 | await expect(page.locator(`.empty`)).toHaveCount(1)
74 | })
75 | })
at /home/runner/work/cmdk/cmdk/test/basic.test.ts:72:41
|
Run pnpm test || exit 1:
test/keybind.test.ts#L1
3) [webkit] › keybind.test.ts:110:7 › no-vim keybinds › ctrl j/k does nothing ────────────────────
Test timeout of 5000ms exceeded.
|
Run pnpm test || exit 1:
test/keybind.test.ts#L113
3) [webkit] › keybind.test.ts:110:7 › no-vim keybinds › ctrl j/k does nothing ────────────────────
Error: expect(locator).toHaveAttribute(expected)
Locator: locator('[cmdk-item][aria-selected="true"]')
Expected string: "first"
Received string: "A"
Call log:
- expect.toHaveAttribute with timeout 5000ms
- waiting for locator('[cmdk-item][aria-selected="true"]')
- locator resolved to <div cmdk-item="" role="option" data-value="A" id="ra…>A</div>
- unexpected value "A"
- locator resolved to <div cmdk-item="" role="option" data-value="A" id="ra…>A</div>
- unexpected value "A"
- locator resolved to <div cmdk-item="" role="option" data-value="A" id="ra…>A</div>
- unexpected value "A"
- locator resolved to <div cmdk-item="" role="option" data-value="A" id="ra…>A</div>
- unexpected value "A"
- locator resolved to <div cmdk-item="" role="option" data-value="A" id="ra…>A</div>
- unexpected value "A"
- locator resolved to <div cmdk-item="" role="option" data-value="A" id="ra…>A</div>
- unexpected value "A"
- locator resolved to <div cmdk-item="" role="option" data-value="A" id="ra…>A</div>
- unexpected value "A"
- locator resolved to <div cmdk-item="" role="option" data-value="A" id="ra…>A</div>
- unexpected value "A"
111 | await expect(page.locator(`[cmdk-item][aria-selected="true"]`)).toHaveAttribute('data-value', 'first')
112 | await page.locator(`[cmdk-input]`).press('Control+j')
> 113 | await expect(page.locator(`[cmdk-item][aria-selected="true"]`)).toHaveAttribute('data-value', 'first')
| ^
114 | await page.locator(`[cmdk-input]`).press('Control+k')
115 | await expect(page.locator(`[cmdk-item][aria-selected="true"]`)).toHaveAttribute('data-value', 'first')
116 | })
at /home/runner/work/cmdk/cmdk/test/keybind.test.ts:113:69
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Run pnpm test || exit 1:
[webkit] › basic.test.ts#L1
[webkit] › basic.test.ts took 17.9s
|
Run pnpm test || exit 1
3 flaky
[webkit] › basic.test.ts:23:7 › basic behavior › item onSelect is called on click ──────────────
[webkit] › basic.test.ts:66:7 › basic behavior › className is applied to each part ─────────────
[webkit] › keybind.test.ts:110:7 › no-vim keybinds › ctrl j/k does nothing ─────────────────────
38 passed (38.6s)
|
Loading