Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pulling new releases into CentOS Stream #2068

Open
4 of 9 tasks
Tracked by #2106
lbarcziova opened this issue May 25, 2023 · 8 comments
Open
4 of 9 tasks
Tracked by #2106

Support pulling new releases into CentOS Stream #2068

lbarcziova opened this issue May 25, 2023 · 8 comments
Assignees
Labels
area/rhel-ecosystem RHEL & CentOS stream complexity/epic Lost of work ahead, planning/design required. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/feature New feature or a request for enhancement.

Comments

@lbarcziova
Copy link
Member

lbarcziova commented May 25, 2023

CC @cathay4t

@lbarcziova lbarcziova added kind/feature New feature or a request for enhancement. complexity/single-task Regular task, should be done within days. area/rhel-ecosystem RHEL & CentOS stream impact/low This issue impacts only a few users. gain/high This brings a lot of value to (not strictly a lot of) users. labels May 25, 2023
@lbarcziova lbarcziova moved this from new to backlog in Packit Kanban Board May 25, 2023
@lachmanfrantisek lachmanfrantisek changed the title Support release syncing to CentOS Stream Support pulling new releases into CentOS Stream Sep 21, 2023
@lachmanfrantisek lachmanfrantisek added impact/high This issue impacts multiple/lot of users. and removed impact/low This issue impacts only a few users. labels Sep 21, 2023
@mfocko
Copy link
Member

mfocko commented Sep 21, 2023

I had a look at it… It is a bit more complicated to resolve:

  • parsing is not affected that much, yet
    • we should make sure we're using the correct package name for both Fedora and CentOS
    • we should include the CentOS dist-git
  • handling of the CentOS v. Fedora should be separated, since they depend on the dist-git included in the API and we can have only one dist-git, duh…
    • having a separate “package” (one for Fedora, one for CentOS) in Packit config might ease this a lot, since there are different dist_git_branches and each “package” would have its own downstream counterpart, there would be 2 separate Celery tasks for handling this, thus resolving the PackitAPI issue
  • given the two points above, it would probably make sense to extend the event to hold dist-git URLs instead of just the one

@lachmanfrantisek lachmanfrantisek moved this from backlog to ready-to-refine in Packit Kanban Board Oct 5, 2023
@lbarcziova
Copy link
Member Author

The person who will pick this should make sure this is everything that needs to be changed and in case there is more, create follow-up issues.

@lbarcziova lbarcziova moved this from ready-to-refine to refined in Packit Kanban Board Oct 5, 2023
@mfocko mfocko self-assigned this Oct 7, 2023
@mfocko mfocko moved this from refined to in-progress in Packit Kanban Board Oct 7, 2023
@nforro
Copy link
Member

nforro commented Oct 8, 2023

I wonder if this actually makes sense. We react to org.fedoraproject.prod.hotness.update.bug.file messages, which effectively means release-monitoring.org projects that have Fedora mapping configured and monitoring enabled at src.fedoraproject.org. Shouldn't we rather react to org.release-monitoring.prod.anitya.project.version.update messages and check for Fedora/CentOS mapping and continue from there?

@mfocko mfocko moved this from in-progress to refined in Packit Kanban Board Oct 8, 2023
@lachmanfrantisek
Copy link
Member

@nforro Thanks for bringing this up.

If I remember correctly, we've picked this option to have some pre-filtering done by the New Hotness but I am now not sure, what pre-filtering is being done here and if it still makes sense. We can ask Michal.

@nforro
Copy link
Member

nforro commented Oct 9, 2023

Yes, I suppose the monitoring option in Pagure does filter out some unwanted traffic, and it makes complete sense to take advantage of it in Fedora, but not so much in CentOS. What if there is a package that is EL-only?

@lbarcziova
Copy link
Member Author

@nforro is right that the messages we currently listen to are filtered in a way that there needs to be mapping to Fedora for the particular package. Besides that, New Hotness does other prefiltering, see the code, e.g. the monitoring enabled in Fedora dist-git, whether the version is newer, whether the package is not retired etc. If we want to support CentOS only packages, we would need to do what Nikola proposes. And in that case, maybe implement the additional checks ourselves.

@mfocko mfocko added the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Oct 11, 2023
@mfocko
Copy link
Member

mfocko commented Oct 12, 2023

Architecture discussion notes

  • keep reacting to org.fedoraproject.prod.hotness.update.bug.file for Fedora
  • org.release-monitoring.prod.anitya.project.version.update for CentOS (and potentially if an RFE occurs for older releases of Fedora)
  • keep in mind not to react to both for Fedora (i.e. don't create duplicate PRs)
  • check the events for potential naming discrepancies between Fedora and CentOS
    • rely on users to make sure they're correct

@nforro nforro removed the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Oct 12, 2023
@mfocko mfocko moved this from refined to in-progress in Packit Kanban Board Oct 12, 2023
@mfocko mfocko linked a pull request Oct 17, 2023 that will close this issue
@mfocko mfocko removed a link to a pull request Oct 17, 2023
softwarefactory-project-zuul bot added a commit to packit/deployment that referenced this issue Oct 17, 2023
Subscribe to Anitya messages

Related to packit/packit-service#2068

Reviewed-by: Laura Barcziová
softwarefactory-project-zuul bot added a commit to packit/packit-service-fedmsg that referenced this issue Oct 18, 2023
Pass Anitya

Related to packit/packit-service#2068

Reviewed-by: Laura Barcziová
Reviewed-by: Matej Focko
@ckelleyRH
Copy link

@mfocko - FYI I am happy to do "real world" battle testing of Packit -> CentOS Stream things as and when it is useful. I am part of the OSCI team responsible for Stream/RHEL and I have some packages in Fedora/Stream/RHEL that I maintain primarily to dogfood the whole packaging experience holistically.

mfocko pushed a commit to packit/deployment that referenced this issue Jan 21, 2024
Subscribe to Anitya messages

Related to packit/packit-service#2068

Reviewed-by: Laura Barcziová
@mfocko mfocko mentioned this issue Feb 14, 2024
6 tasks
softwarefactory-project-zuul bot added a commit that referenced this issue Mar 13, 2024
Feat/centos anitya

Add an event class
 Implement a parser
 Pass around versions in a list (for New Hotness we can have just one version in the list, for Anitya version update fail)
 Do not generate DB entry from the event
 ⚠️ Choosing the correct version

Outcomes from the arch:

Gather more use cases
Require the explicit setting for version mask (for CentOS at least)




 ⚠️ Decide whether to support Fedora for Anitya version update too… right now it's prefiltered for the CentOS

Related to #2068

Reviewed-by: Matej Focko
Reviewed-by: Laura Barcziová
@mfocko mfocko added complexity/epic Lost of work ahead, planning/design required. and removed complexity/single-task Regular task, should be done within days. labels May 6, 2024
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 20, 2024
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 20, 2024
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 20, 2024
lbarcziova added a commit to lbarcziova/packit that referenced this issue May 20, 2024
softwarefactory-project-zuul bot added a commit to packit/packit that referenced this issue May 29, 2024
Allow passing versions as list for sync_release

Fixes packit/packit-service#2408
Related to packit/packit-service#2068
Allow passing it as a new parameter to be explicit. With this, the CLI/service doesn't need to be touched for now and in followup implementation (next points in packit/packit-service#2068) the list will be passed only for AnityaVersionUpdateEvent.
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: Matej Focko
Reviewed-by: Laura Barcziová
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rhel-ecosystem RHEL & CentOS stream complexity/epic Lost of work ahead, planning/design required. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/feature New feature or a request for enhancement.
Projects
Status: in-progress
Development

No branches or pull requests

5 participants