-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pulling new releases into CentOS Stream #2068
Comments
I had a look at it… It is a bit more complicated to resolve:
|
The person who will pick this should make sure this is everything that needs to be changed and in case there is more, create follow-up issues. |
I wonder if this actually makes sense. We react to |
@nforro Thanks for bringing this up. If I remember correctly, we've picked this option to have some pre-filtering done by the New Hotness but I am now not sure, what pre-filtering is being done here and if it still makes sense. We can ask Michal. |
Yes, I suppose the monitoring option in Pagure does filter out some unwanted traffic, and it makes complete sense to take advantage of it in Fedora, but not so much in CentOS. What if there is a package that is EL-only? |
@nforro is right that the messages we currently listen to are filtered in a way that there needs to be mapping to Fedora for the particular package. Besides that, New Hotness does other prefiltering, see the code, e.g. the monitoring enabled in Fedora dist-git, whether the version is newer, whether the package is not retired etc. If we want to support CentOS only packages, we would need to do what Nikola proposes. And in that case, maybe implement the additional checks ourselves. |
Architecture discussion notes
|
Subscribe to Anitya messages Related to packit/packit-service#2068 Reviewed-by: Laura Barcziová
Pass Anitya Related to packit/packit-service#2068 Reviewed-by: Laura Barcziová Reviewed-by: Matej Focko
@mfocko - FYI I am happy to do "real world" battle testing of Packit -> CentOS Stream things as and when it is useful. I am part of the OSCI team responsible for Stream/RHEL and I have some packages in Fedora/Stream/RHEL that I maintain primarily to dogfood the whole packaging experience holistically. |
Subscribe to Anitya messages Related to packit/packit-service#2068 Reviewed-by: Laura Barcziová
Feat/centos anitya Add an event class Implement a parser Pass around versions in a list (for New Hotness we can have just one version in the list, for Anitya version update fail) Do not generate DB entry from the event⚠️ Choosing the correct version Outcomes from the arch: Gather more use cases Require the explicit setting for version mask (for CentOS at least)⚠️ Decide whether to support Fedora for Anitya version update too… right now it's prefiltered for the CentOS Related to #2068 Reviewed-by: Matej Focko Reviewed-by: Laura Barcziová
Allow passing versions as list for sync_release Fixes packit/packit-service#2408 Related to packit/packit-service#2068 Allow passing it as a new parameter to be explicit. With this, the CLI/service doesn't need to be touched for now and in followup implementation (next points in packit/packit-service#2068) the list will be passed only for AnityaVersionUpdateEvent. RELEASE NOTES BEGIN N/A RELEASE NOTES END Reviewed-by: Matej Focko Reviewed-by: Laura Barcziová
https://github.com/fedora-infra/the-new-hotness/blob/363acd33623dadd5fc3b60a83a528926c7c21fc1/hotness/hotness_consumer.py#L461
CC @cathay4t
The text was updated successfully, but these errors were encountered: