Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission checks are done per-job, not per-installation #1850

Open
1 of 6 tasks
lachmanfrantisek opened this issue Jan 16, 2023 · 2 comments
Open
1 of 6 tasks

Permission checks are done per-job, not per-installation #1850

lachmanfrantisek opened this issue Jan 16, 2023 · 2 comments
Labels
complexity/epic Lost of work ahead, planning/design required.

Comments

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Jan 16, 2023

This task is to not do any permission check right after the Packit service setup but to do it on a job-level basis.

Why?

  • We already have a few job-only checks.
  • We don't need to require permissions that are not relevant when a user doesn't use a particular job.
  • For GitLab, the automatic FAS mapping after the installation does not work => we need to handle this somehow. (Related to "Approval" section in docs not applicable for Gitlab upstreams #1707 )
  • Requirements can be more easily documented and the reasoning is easier to provide.

TODO:

@lachmanfrantisek lachmanfrantisek added the complexity/epic Lost of work ahead, planning/design required. label Jan 16, 2023
@lbarcziova
Copy link
Member

Output from Packit 2023/Q1 planning meeting:

  • What's the benefit?
    easier, clearer installation for the users; better UX in general

  • Who will benefit?
    all (new) users

@lachmanfrantisek
Copy link
Member Author

After a team discussion, we didn't pick this as a top Packit team priority for the next quarter and preferred epics with bigger user benefits. (Sadly, we have limited resources.) If anyone wants to help us with this, we will be really glad. We are open to any collaboration and have successfully implemented/started multiple affords thanks to people outside of the Packit team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity/epic Lost of work ahead, planning/design required.
Projects
Status: in-progress
Development

No branches or pull requests

2 participants