Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins pipeline update #107

Merged
merged 7 commits into from
Dec 18, 2019
Merged

Jenkins pipeline update #107

merged 7 commits into from
Dec 18, 2019

Conversation

nikola-rados
Copy link
Contributor

@nikola-rados nikola-rados commented Nov 15, 2019 •
edited
Loading

Add features to Jenkinsfile for pipeline.

Features added:

  • automatically push images to docker hub using jenkins user
  • updated naming to accommodate docker hub (ex. pcic/[tool_name]:[branch_name])
  • conduct security scan of image
  • automate cleanup docker image on dev01

@nikola-rados
Copy link
Contributor Author

@jameshiebert I didn't realize this branch never got merged. I've applied the same updates created in climate-explorer-frontend PR #351. This includes:

  • tag tracking
  • reduced usage of security scan
  • more consistent image naming

@jameshiebert
Copy link
Contributor

Looks good to me. Sorry that this got dropped!

@jameshiebert jameshiebert merged commit b3b1562 into master Dec 18, 2019
@jameshiebert jameshiebert deleted the jenkins-pipeline-update branch December 18, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshiebert jameshiebert Awaiting requested review from jameshiebert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikola-rados @jameshiebert